Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a minor bug in the default value of the bridge command #488

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Fixing a minor bug in the default value of the bridge command #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce1c151
fix: bug with default bridge value
praetoriansentry Jan 30, 2025
62371fb
Merge branch 'main' into jhilliard/ulxly-default-value
praetoriansentry Jan 30, 2025
3d66aa8
fix: merge issue
praetoriansentry Jan 30, 2025
0b65fe2
fix: docs
praetoriansentry Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cmd/ulxly/ulxly.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1415,11 +1415,10 @@ or if it's actually an intermediate hash.`,

// bridge specific args
inputUlxlyArgs.forceUpdate = ulxlyBridgeCmd.PersistentFlags().Bool(ArgForceUpdate, true, "indicates if the new global exit root is updated or not")
inputUlxlyArgs.value = ulxlyBridgeCmd.PersistentFlags().String(ArgValue, "", "the amount in wei to be sent along with the transaction")
inputUlxlyArgs.value = ulxlyBridgeCmd.PersistentFlags().String(ArgValue, "0", "the amount in wei to be sent along with the transaction")
inputUlxlyArgs.destNetwork = ulxlyBridgeCmd.PersistentFlags().Uint32(ArgDestNetwork, 0, "the rollup id of the destination network")
inputUlxlyArgs.tokenAddress = ulxlyBridgeCmd.PersistentFlags().String(ArgTokenAddress, "0x0000000000000000000000000000000000000000", "the address of an ERC20 token to be used")
inputUlxlyArgs.callData = ulxlyBridgeCmd.PersistentFlags().String(ArgCallData, "0x", "call data to be passed directly with bridge-message or as an ERC20 Permit")
inputUlxlyArgs.callDataFile = ulxlyBridgeCmd.PersistentFlags().String(ArgCallDataFile, "", "a file containing hex encoded call data")
fatalIfError(ulxlyBridgeCmd.MarkPersistentFlagRequired(ArgDestNetwork))

// Claim specific args
Expand Down
3 changes: 1 addition & 2 deletions doc/polycli_ulxly__bridge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@ Commands for moving funds and sending messages from one chain to another

```bash
--call-data string call data to be passed directly with bridge-message or as an ERC20 Permit (default "0x")
--call-data-file string a file containing hex encoded call data
--destination-network uint32 the rollup id of the destination network
--force-update-root indicates if the new global exit root is updated or not (default true)
-h, --help help for bridge
--token-address string the address of an ERC20 token to be used (default "0x0000000000000000000000000000000000000000")
--value string the amount in wei to be sent along with the transaction
--value string the amount in wei to be sent along with the transaction (default "0")
```

The command also inherits flags from parent commands.
Expand Down
3 changes: 1 addition & 2 deletions doc/polycli_ulxly__bridge_asset.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ The command also inherits flags from parent commands.
```bash
--bridge-address string the address of the lxly bridge
--call-data string call data to be passed directly with bridge-message or as an ERC20 Permit (default "0x")
--call-data-file string a file containing hex encoded call data
--chain-id string set the chain id to be used in the transaction
--config string config file (default is $HOME/.polygon-cli.yaml)
--destination-address string the address where the bridge will be sent to
Expand All @@ -114,7 +113,7 @@ The command also inherits flags from parent commands.
--rpc-url string the URL of the RPC to send the transaction
--token-address string the address of an ERC20 token to be used (default "0x0000000000000000000000000000000000000000")
--transaction-receipt-timeout uint the amount of time to wait while trying to confirm a transaction receipt (default 60)
--value string the amount in wei to be sent along with the transaction
--value string the amount in wei to be sent along with the transaction (default "0")
-v, --verbosity int 0 - Silent
100 Panic
200 Fatal
Expand Down
3 changes: 1 addition & 2 deletions doc/polycli_ulxly__bridge_message.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ The command also inherits flags from parent commands.
```bash
--bridge-address string the address of the lxly bridge
--call-data string call data to be passed directly with bridge-message or as an ERC20 Permit (default "0x")
--call-data-file string a file containing hex encoded call data
--chain-id string set the chain id to be used in the transaction
--config string config file (default is $HOME/.polygon-cli.yaml)
--destination-address string the address where the bridge will be sent to
Expand All @@ -111,7 +110,7 @@ The command also inherits flags from parent commands.
--rpc-url string the URL of the RPC to send the transaction
--token-address string the address of an ERC20 token to be used (default "0x0000000000000000000000000000000000000000")
--transaction-receipt-timeout uint the amount of time to wait while trying to confirm a transaction receipt (default 60)
--value string the amount in wei to be sent along with the transaction
--value string the amount in wei to be sent along with the transaction (default "0")
-v, --verbosity int 0 - Silent
100 Panic
200 Fatal
Expand Down
3 changes: 1 addition & 2 deletions doc/polycli_ulxly__bridge_weth.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ The command also inherits flags from parent commands.
```bash
--bridge-address string the address of the lxly bridge
--call-data string call data to be passed directly with bridge-message or as an ERC20 Permit (default "0x")
--call-data-file string a file containing hex encoded call data
--chain-id string set the chain id to be used in the transaction
--config string config file (default is $HOME/.polygon-cli.yaml)
--destination-address string the address where the bridge will be sent to
Expand All @@ -80,7 +79,7 @@ The command also inherits flags from parent commands.
--rpc-url string the URL of the RPC to send the transaction
--token-address string the address of an ERC20 token to be used (default "0x0000000000000000000000000000000000000000")
--transaction-receipt-timeout uint the amount of time to wait while trying to confirm a transaction receipt (default 60)
--value string the amount in wei to be sent along with the transaction
--value string the amount in wei to be sent along with the transaction (default "0")
-v, --verbosity int 0 - Silent
100 Panic
200 Fatal
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ require (
github.com/cenkalti/backoff/v4 v4.3.0
github.com/chzyer/readline v1.5.1 // indirect
github.com/cockroachdb/pebble v1.1.4
github.com/ethereum/go-ethereum v1.14.12
github.com/ethereum/go-ethereum v1.14.13
github.com/gizak/termui/v3 v3.1.1-0.20231111080052-b3569a6cd52d
github.com/google/gofuzz v1.2.0
github.com/hashicorp/golang-lru v1.0.2
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@ github.com/envoyproxy/go-control-plane v0.9.4/go.mod h1:6rpuAdCZL397s3pYoYcLgu1m
github.com/envoyproxy/protoc-gen-validate v0.1.0/go.mod h1:iSmxcyjqTsJpI2R4NaDN7+kN2VEUnK/pcBlmesArF7c=
github.com/ethereum/c-kzg-4844 v1.0.3 h1:IEnbOHwjixW2cTvKRUlAAUOeleV7nNM/umJR+qy4WDs=
github.com/ethereum/c-kzg-4844 v1.0.3/go.mod h1:VewdlzQmpT5QSrVhbBuGoCdFJkpaJlO1aQputP83wc0=
github.com/ethereum/go-ethereum v1.14.12 h1:8hl57x77HSUo+cXExrURjU/w1VhL+ShCTJrTwcCQSe4=
github.com/ethereum/go-ethereum v1.14.12/go.mod h1:RAC2gVMWJ6FkxSPESfbshrcKpIokgQKsVKmAuqdekDY=
github.com/ethereum/go-ethereum v1.14.13 h1:L81Wmv0OUP6cf4CW6wtXsr23RUrDhKs2+Y9Qto+OgHU=
github.com/ethereum/go-ethereum v1.14.13/go.mod h1:RAC2gVMWJ6FkxSPESfbshrcKpIokgQKsVKmAuqdekDY=
github.com/ethereum/go-verkle v0.2.2 h1:I2W0WjnrFUIzzVPwm8ykY+7pL2d4VhlsePn4j7cnFk8=
github.com/ethereum/go-verkle v0.2.2/go.mod h1:M3b90YRnzqKyyzBEWJGqj8Qff4IDeXnzFw0P9bFw3uk=
github.com/felixge/httpsnoop v1.0.4 h1:NFTV2Zj1bL4mc9sqWACXbQFVBBg2W3GPvqp8/ESS2Wg=
Expand Down
Loading