fix: dockerfile build #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leovct
reviewed
Jan 20, 2025
There was a problem hiding this comment.
I tested a few commands but looks like it's not working properly? (tested on m1 mac)
$ docker run polycli:latest version
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "version": executable file not found in $PATH: unknown.
$ docker run -it polycli:latest monitor --rpc-url https://polygon-rpc.com
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "monitor": executable file not found in $PATH: unknown.
Signed-off-by: Ji Hwan <[email protected]>
jhkimqd
force-pushed
the
jihwan/dockerfile
branch
from
5a022c0 to
75307d6
Compare
Signed-off-by: Ji Hwan <[email protected]>
jhkimqd
force-pushed
the
jihwan/dockerfile
branch
from
980274a to
228120a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the dockerfile build and adds a separate
makecommandmake build-dockerto build the docker images.