Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-55 Addresses #169

Merged
merged 1 commit into from
Nov 28, 2023
Merged

EIP-55 Addresses #169

merged 1 commit into from
Nov 28, 2023

Conversation

praetoriansentry
Copy link
Member

@praetoriansentry praetoriansentry commented Nov 28, 2023 •
edited
Loading

Description

The output from polycli wallet outputs normal hex formatted ETH addresses. This is causing validation issues in some cases:
image

To fix, I'm just using the go-etherum/common package to convert the bytes to an address and then using String() which seems to be EIP-55 friendly.

Tests

image

polycli wallet inspect --mnemonic 'code code code code code code code code code code code quality' | jq '.Addresses[0].ETHAddress'

@praetoriansentry praetoriansentry marked this pull request as ready for review November 28, 2023 22:29
rebelArtists
rebelArtists approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@rebelArtists rebelArtists left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@praetoriansentry praetoriansentry merged commit 1b893ca into main Nov 28, 2023
6 checks passed
@praetoriansentry praetoriansentry deleted the jhilliard/ethaddress-format branch November 28, 2023 23:07
leovct
leovct reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's funny, I also had to fix that to be able to derive wallets from mnemonic in polycli fund. I didn't want to mess with toEthAddress so I ended up creating a new multiAddress field to do exactly that. I'll merge you changes in my branch, thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovct leovct leovct left review comments

@rebelArtists rebelArtists rebelArtists approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praetoriansentry @leovct @rebelArtists