Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: refactor gen job #168

Merged
merged 11 commits into from
Nov 29, 2023
Merged

ci: refactor gen job #168

merged 11 commits into from
Nov 29, 2023

Conversation

leovct
Copy link
Member

@leovct leovct commented Nov 28, 2023 •
edited
Loading

Description

  • Instead of having multiple jobs that check if generated files are up to date (check-documentation, check-go-bindings, etc.), we can regroup all these jobs into one called gen.
  • Add Makefile helpers to generate files.
  • Generate new version of the files (go bindings, proto stubs etc.)
  • Clean up CI jobs.

Jira / Linear Tickets

Testing

  • New CI job should pass

@leovct leovct marked this pull request as ready for review November 28, 2023 11:59
@leovct leovct requested a review from a team November 28, 2023 11:59
gatsbyz
gatsbyz approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@gatsbyz gatsbyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@gatsbyz
Copy link
Contributor

gatsbyz commented Nov 28, 2023 •
edited
Loading

should we just automate make gen-doc commits into the CI flow. since it's checking if it's done already anyways

@leovct
Copy link
Member Author

leovct commented Nov 29, 2023

should we just automate make gen-doc commits into the CI flow. since it's checking if it's done already anyways

Why not, we can discuss this with the team :)

@leovct leovct merged commit b505e3c into main Nov 29, 2023
6 checks passed
@leovct leovct deleted the ci/add-gen-job branch November 29, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gatsbyz gatsbyz gatsbyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leovct @gatsbyz