-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve polycli fund
#167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 49c2676.
@rebelArtists A couple of changes since last review.
|
rebelArtists
previously approved these changes
Nov 28, 2023
IdrisHanafi
reviewed
Nov 29, 2023
IdrisHanafi
reviewed
Nov 29, 2023
IdrisHanafi
reviewed
Nov 29, 2023
IdrisHanafi
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job, lgtm 🔥
tried testing it out with the sample commands in the PR description:
polycli fund --wallets 20 --verbosity 500
but realized, the flag has been changed from wallets
to number
lol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
web3
library togo-ethereum
.Funder
smart contract to be able to bulk fund wallets in one transaction. It speeds up the funding process by a lot. 🚀PreRunE
and move flag logic toapp
.RunE
instead ofRunE
when running thefund
command.--eth-amount
inpolycli loadtest
. Users can now specify the amount in eth instead of having to specify the hexadecimal representation of the amount in wei.Jira / Linear Tickets
go-ethereum
lib.Testing
Extract from
wallets.json
.Check the balances of the wallets.
Send funds on behalf on one of the funded account.
$ cast send --private-key e211490bcaae916e6cdbf58877e7fc697a51c6e11cfe591b0b2b72e6123e4d12 --value 0.01ether 0x469838206407A001B7086F102fe35b62967170d3 blockHash 0xd9dbd1b377d75cb3704c2e1ca27b3054e18afe692abed8eb621a4a231446adfb blockNumber 8 contractAddress cumulativeGasUsed 21000 effectiveGasPrice 3401058594 gasUsed 21000 logs [] logsBloom 0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 root status 1 transactionHash 0x530d68a9f705e02fcf02362e1e75cdeb76e49f2bd9df165f6c447df512652367 transactionIndex 0 type 2