Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support tools for DeepSeek provider #251

Merged
merged 4 commits into from
Jan 30, 2025
Merged

feat: support tools for DeepSeek provider #251

merged 4 commits into from
Jan 30, 2025

Conversation

carlos-verdes
Copy link
Contributor

Fixes #250

@carlos-verdes
Copy link
Contributor Author

@cvauclair take a look into this one, I think it's an important one

@carlos-verdes
Copy link
Contributor Author

@maxsorto can you take a look into this?

@joshua-mo-143 joshua-mo-143 self-requested a review January 29, 2025 22:01
@joshua-mo-143
Copy link
Contributor

Hi Carlos, thanks for this PR! It is currently quite late but when I am available tomorrow I'll be reviewing this.

joshua-mo-143
joshua-mo-143 requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@joshua-mo-143 joshua-mo-143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR Carlos! Just need to fix the pending issues then we should be good to go.

rig-core/Cargo.toml Outdated Show resolved Hide resolved
rig-core/examples/agent_with_deepseek.rs Outdated Show resolved Hide resolved
rig-core/examples/agent_with_tools.rs Outdated Show resolved Hide resolved
rig-core/examples/agent_with_tools.rs Outdated Show resolved Hide resolved
@carlos-verdes
Copy link
Contributor Author

@joshua-mo-143 changes applied

@joshua-mo-143 joshua-mo-143 merged commit e27b0aa into 0xPlaygrounds:main Jan 30, 2025
5 checks passed
This was referenced Jan 30, 2025
Closed
Merged
Closed
Closed
@github-actions github-actions bot mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshua-mo-143 joshua-mo-143 joshua-mo-143 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeepSeek Completion support for tools
2 participants
@carlos-verdes @joshua-mo-143