-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add EpubFileLoader for EPUB file processing #192
base: main
Are you sure you want to change the base?
Conversation
Great work on this, will be reviewing this soon! I love how you added a |
Thank you for the feedback! I spent some time understanding how the loader works, and that took the most effort. Compared to researching the existing ones, implementing the new loader took significantly less time. I really like the concept of the type state pattern.
Yes, it does look confusing, but it’s effective at the same time. I’m experimenting with a few improvement options, and if something works out, I’ll share an example. |
Hey, wanted to check up on this. Were you going to introduce anything extra here or is this ready for review? It does look like you need to rebase to main to ensure that this can be merged w/o conflicts. When resolved, you can mark me for review! |
Hi! I've resolved conflicts using the GitHub tool. Let me know if rebase is mandatory; I'll squash commits locally and push them to the branch. The PR is ready to be reviewed. No additional changes aren't going to be added for now, maybe in the next PRs. |
@danik-tro Could this PR be rebased / merged w/ main! thanks! |
Add EpubFileLoader for EPUB file processing.
Solves #160
Changes
EpubFileLoader
, inrig-core/src/loaders/epub.rs
under theepub
feature.epub-rs
for handling EPUB files.EpubFileLoader
for stripping XML tags to produce plain text.