Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Spicy and HILTI attributes separately #1955

Open
bbannier opened this issue Jan 8, 2025 · 0 comments
Open

Model Spicy and HILTI attributes separately #1955

bbannier opened this issue Jan 8, 2025 · 0 comments
Labels

Comments

@bbannier
Copy link
Member

bbannier commented Jan 8, 2025

Current HILTI attribute::Kind holds both Spicy as well as HILTI attributes (e.g., parse-at cannot appear in HILTI code). We should attempt to model them separately; this might not be trivial since in C++ enums cannot be inherited.

I realized we have another issue with the new Kind enum: Spicy-side values now reside inside HILTI headers, which isn't great (things like MaxSize and ParseAt is nothing that HILTI should know about). Not immediately sure how to fix that, it's really like we'd need two enum types.

Originally posted by @rsmmr in #1936 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant