Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacks with a weight of 0 are shown as receiving 0% traffic #449

Open
musiKk opened this issue Feb 15, 2017 · 0 comments
Open

Stacks with a weight of 0 are shown as receiving 0% traffic #449

musiKk opened this issue Feb 15, 2017 · 0 comments

Comments

@musiKk
Copy link

musiKk commented Feb 15, 2017

We currently have some stacks where all aliases in Route 53 have 0. I don't know how this happened and that is a different problem anyway. However, senza traffic lists all stacks with 0% traffic when in fact they all receive an equal amount of traffic. So for example if one stack has two versions and both have a DNS weight of 0 then senza should say 50% for both.

I think the issue is here but I'm not sure. It seems all stacks with a weight of 0 are filtered out which misses the corner case of all stacks having a 0.

This is probably (i.e. haven't tested it) also a problem for the traffic detection of senza delete which only checks for a Route 53 weight greater than zero. While I'm not mindlessly going around deleting stacks, I'm relying on this feature as a safeguard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants