Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include duration in logs when evicting pods #29

Open
mikkeloscar opened this issue May 24, 2018 · 2 comments
Open

Include duration in logs when evicting pods #29

mikkeloscar opened this issue May 24, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mikkeloscar
Copy link
Contributor

mikkeloscar commented May 24, 2018

Would be nice if the CLM logged for how long it had tried to evict each pod, to make it more clear which pods are not evictable for a long time.

@mikkeloscar mikkeloscar added the enhancement New feature or request label May 24, 2018
@gargravarr gargravarr self-assigned this Sep 23, 2019
@AlexanderYastrebov
Copy link
Member

I think it eventually logs how long it took to complete

localLogger.Infof("Pod evicted. (Observed termination period: %s)", time.Now().UTC().Sub(start))

which takes up to
gracePeriod := time.Duration(*pod.Spec.TerminationGracePeriodSeconds)*time.Second + podEvictionHeadroom

I am not sure it makes sense to log the retry progress as that may unnecessary pollute logs.

@aermakov-zalando
Copy link
Contributor

This is about force eviction (kubernetes delete -> grace period -> pod deletion), I think Mikkel meant the total time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants