diff --git a/Directory.Build.props b/Directory.Build.props index b9439a50eae4..56ab2370c313 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -2,7 +2,6 @@ net8.0 - 11.0 Umbraco HQ Umbraco Copyright © Umbraco $([System.DateTime]::Today.ToString('yyyy')) @@ -17,6 +16,7 @@ nullable enable true + false @@ -35,21 +35,16 @@ true - - - - - - + + + $(MSBuildThisFileDirectory) + + - - $(MSBuildThisFileDirectory) - - diff --git a/src/Directory.Packages.props b/Directory.Packages.props similarity index 70% rename from src/Directory.Packages.props rename to Directory.Packages.props index bfa71d3932f3..0f28210de30f 100644 --- a/src/Directory.Packages.props +++ b/Directory.Packages.props @@ -2,47 +2,69 @@ true - NU1507 + true + + + + + + + + + + - - - - - - - - - - + - - + + + + + + + - - - - - + + + + + + + + + + + + + + + + + + + + + + - - - - + + + @@ -55,16 +77,20 @@ - - + + - - - - - - - + + + + + + + + + + + - \ No newline at end of file + diff --git a/nuget.config b/nuget.config new file mode 100644 index 000000000000..e94f426facdf --- /dev/null +++ b/nuget.config @@ -0,0 +1,13 @@ + + + + + + + + + + + + + diff --git a/src/Umbraco.Cms.Imaging.ImageSharp/Media/ImageSharpImageUrlGenerator.cs b/src/Umbraco.Cms.Imaging.ImageSharp/Media/ImageSharpImageUrlGenerator.cs index afcd0f35a2e1..25c964186f9f 100644 --- a/src/Umbraco.Cms.Imaging.ImageSharp/Media/ImageSharpImageUrlGenerator.cs +++ b/src/Umbraco.Cms.Imaging.ImageSharp/Media/ImageSharpImageUrlGenerator.cs @@ -130,11 +130,7 @@ internal ImageSharpImageUrlGenerator(IEnumerable supportedImageFileTypes { var uri = QueryHelpers.AddQueryString(options.ImageUrl, queryString); - // It's important that we call the async version here. - // This is because if we call the synchronous version, we ImageSharp will start a new Task ever single time. - // This becomes a huge problem if the site is under load, and will result in massive spikes in response time. - // See https://github.com/SixLabors/ImageSharp.Web/blob/main/src/ImageSharp.Web/AsyncHelper.cs#L24 - var token = _requestAuthorizationUtilities.ComputeHMACAsync(uri, CommandHandling.Sanitize).GetAwaiter().GetResult(); + var token = _requestAuthorizationUtilities.ComputeHMAC(uri, CommandHandling.Sanitize); if (string.IsNullOrEmpty(token) is false) { queryString.Add(RequestAuthorizationUtilities.TokenCommand, token); diff --git a/src/Umbraco.Cms.Imaging.ImageSharp/Umbraco.Cms.Imaging.ImageSharp.csproj b/src/Umbraco.Cms.Imaging.ImageSharp/Umbraco.Cms.Imaging.ImageSharp.csproj index bb9b44cf5184..13126a24b545 100644 --- a/src/Umbraco.Cms.Imaging.ImageSharp/Umbraco.Cms.Imaging.ImageSharp.csproj +++ b/src/Umbraco.Cms.Imaging.ImageSharp/Umbraco.Cms.Imaging.ImageSharp.csproj @@ -2,7 +2,6 @@ Umbraco CMS - Imaging - ImageSharp Adds imaging support using ImageSharp/ImageSharp.Web to Umbraco CMS. - false diff --git a/src/Umbraco.Cms.Imaging.ImageSharp2/Umbraco.Cms.Imaging.ImageSharp2.csproj b/src/Umbraco.Cms.Imaging.ImageSharp2/Umbraco.Cms.Imaging.ImageSharp2.csproj index d55479d8ec7b..1dcba40ab62a 100644 --- a/src/Umbraco.Cms.Imaging.ImageSharp2/Umbraco.Cms.Imaging.ImageSharp2.csproj +++ b/src/Umbraco.Cms.Imaging.ImageSharp2/Umbraco.Cms.Imaging.ImageSharp2.csproj @@ -2,12 +2,11 @@ Umbraco CMS - Imaging - ImageSharp 2 Adds imaging support using ImageSharp/ImageSharp.Web version 2 to Umbraco CMS. - false - - + + diff --git a/src/Umbraco.Cms.Targets/Umbraco.Cms.Targets.csproj b/src/Umbraco.Cms.Targets/Umbraco.Cms.Targets.csproj index b930ff1bc0ad..a02370bb1e88 100644 --- a/src/Umbraco.Cms.Targets/Umbraco.Cms.Targets.csproj +++ b/src/Umbraco.Cms.Targets/Umbraco.Cms.Targets.csproj @@ -4,9 +4,6 @@ Installs Umbraco CMS with minimal dependencies in your ASP.NET Core project. false false - - false - false @@ -24,7 +21,7 @@ NU5100;NU5128 - + diff --git a/src/Umbraco.Cms/Umbraco.Cms.csproj b/src/Umbraco.Cms/Umbraco.Cms.csproj index 8b0dcb8a8766..39a3b03c56bf 100644 --- a/src/Umbraco.Cms/Umbraco.Cms.csproj +++ b/src/Umbraco.Cms/Umbraco.Cms.csproj @@ -4,7 +4,6 @@ Installs Umbraco CMS with all default dependencies in your ASP.NET Core project. false false - false diff --git a/src/Umbraco.Infrastructure/Umbraco.Infrastructure.csproj b/src/Umbraco.Infrastructure/Umbraco.Infrastructure.csproj index a9fef3d046c8..c5a60e8dccc1 100644 --- a/src/Umbraco.Infrastructure/Umbraco.Infrastructure.csproj +++ b/src/Umbraco.Infrastructure/Umbraco.Infrastructure.csproj @@ -12,35 +12,31 @@ - - + + - + - + - + - - - + + + - + - - - - diff --git a/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj b/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj index 0609c216eb37..8e2241564e2e 100644 --- a/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj +++ b/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj @@ -3,20 +3,23 @@ Umbraco.Cms.Web.UI false false - false + + + - + + - + diff --git a/templates/Directory.Build.props b/templates/Directory.Build.props index c4e40e3e066a..4d993c78c8d9 100644 --- a/templates/Directory.Build.props +++ b/templates/Directory.Build.props @@ -1,4 +1,5 @@ + - + diff --git a/templates/Umbraco.Templates.csproj b/templates/Umbraco.Templates.csproj index 6a4d0460d113..0ccbab5e19c6 100644 --- a/templates/Umbraco.Templates.csproj +++ b/templates/Umbraco.Templates.csproj @@ -9,7 +9,6 @@ true . NU5128 - false @@ -44,7 +43,7 @@ - + diff --git a/templates/UmbracoPackage/UmbracoPackage.csproj b/templates/UmbracoPackage/UmbracoPackage.csproj index 98f5bac3ad7d..309bf6b2d222 100644 --- a/templates/UmbracoPackage/UmbracoPackage.csproj +++ b/templates/UmbracoPackage/UmbracoPackage.csproj @@ -1,16 +1,20 @@ net8.0 + enable + enable . - UmbracoPackage + UmbracoPackage + + + UmbracoPackage + UmbracoPackage UmbracoPackage ... umbraco plugin package - UmbracoPackage - false - + diff --git a/templates/UmbracoProject/UmbracoProject.csproj b/templates/UmbracoProject/UmbracoProject.csproj index 1c530223ada2..ee8dd5e56ead 100644 --- a/templates/UmbracoProject/UmbracoProject.csproj +++ b/templates/UmbracoProject/UmbracoProject.csproj @@ -4,7 +4,6 @@ enable enable Umbraco.Cms.Web.UI - false diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props index 1d532e6664f1..49f18af1bd0d 100644 --- a/tests/Directory.Build.props +++ b/tests/Directory.Build.props @@ -1,6 +1,7 @@ + - + diff --git a/tests/Directory.Packages.props b/tests/Directory.Packages.props index 41398eed6e09..a8031cc500e1 100644 --- a/tests/Directory.Packages.props +++ b/tests/Directory.Packages.props @@ -1,24 +1,25 @@ - - true - NU1507 - + + - + + + + + + + + + + + + - - - - - - - - - \ No newline at end of file + diff --git a/tests/Umbraco.Tests.AcceptanceTest/misc/Directory.Packages.props b/tests/Umbraco.Tests.AcceptanceTest/misc/Directory.Packages.props new file mode 100644 index 000000000000..8db7958e5461 --- /dev/null +++ b/tests/Umbraco.Tests.AcceptanceTest/misc/Directory.Packages.props @@ -0,0 +1,7 @@ + + + + diff --git a/tests/Umbraco.Tests.Benchmarks/Umbraco.Tests.Benchmarks.csproj b/tests/Umbraco.Tests.Benchmarks/Umbraco.Tests.Benchmarks.csproj index 09a4600005e0..189d69ac31f8 100644 --- a/tests/Umbraco.Tests.Benchmarks/Umbraco.Tests.Benchmarks.csproj +++ b/tests/Umbraco.Tests.Benchmarks/Umbraco.Tests.Benchmarks.csproj @@ -3,7 +3,6 @@ Exe false false - false false diff --git a/tests/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj b/tests/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj index c4d307047271..56898cebf5e7 100644 --- a/tests/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj +++ b/tests/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj @@ -7,6 +7,7 @@ Umbraco.Cms.Tests.Integration true $(BaseEnablePackageValidation) + NU5100 diff --git a/tools/Umbraco.JsonSchema/Umbraco.JsonSchema.csproj b/tools/Umbraco.JsonSchema/Umbraco.JsonSchema.csproj index 8b6698689877..3e3b2792a8c6 100644 --- a/tools/Umbraco.JsonSchema/Umbraco.JsonSchema.csproj +++ b/tools/Umbraco.JsonSchema/Umbraco.JsonSchema.csproj @@ -3,12 +3,11 @@ Exe false false - false - - + + diff --git a/umbraco.sln b/umbraco.sln index 98a353a38741..517b3959e958 100644 --- a/umbraco.sln +++ b/umbraco.sln @@ -129,12 +129,13 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution .gitignore = .gitignore .globalconfig = .globalconfig Directory.Build.props = Directory.Build.props + Directory.Packages.props = Directory.Packages.props + global.json = global.json icon.png = icon.png LICENSE.md = LICENSE.md umbraco.sln.DotSettings = umbraco.sln.DotSettings + nuget.config = nuget.config version.json = version.json - global.json = global.json - src\Directory.Packages.props = src\Directory.Packages.props EndProjectSection EndProject Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build", "build", "{20CE9C97-9314-4A19-BCF1-D12CF49B7205}"