Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request instructions in CONTRIBUTING.md don't make sense #17

Open
davemq opened this issue Nov 10, 2020 · 1 comment
Open

Pull request instructions in CONTRIBUTING.md don't make sense #17

davemq opened this issue Nov 10, 2020 · 1 comment

Comments

@davemq
Copy link

davemq commented Nov 10, 2020

CONTRIBUTING.md has a set of instructions for pull requests that appear to be for a Ruby project, not an Emacs Lisp project. Is Ruby actually required? If not, the instructions should be updated to cover what would be acceptable for a pull request.
@davemq davemq closed this as completed Nov 10, 2020
@davemq davemq reopened this Nov 10, 2020
@davemq
Copy link
Author

davemq commented Nov 10, 2020

Looking into this further, if one uses vagrant to do testing then bundle and other Ruby tools are installed as prerequisites. But the repository has no spec file and running bundle exec rake spec doesn't work. So there are still issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davemq