Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception handling #176

Open
tfmorris opened this issue Jul 11, 2023 · 0 comments
Open

Fix exception handling #176

tfmorris opened this issue Jul 11, 2023 · 0 comments

Comments

@tfmorris
Copy link

The error reporting mechanism (at least in the Excel code) is to throw new Exception("Some random error message") which then means the caller needs to catch Exception just for run of the mill errors.

Instead a specific Exception subclass should be defined (e.g. PattypanException) which can then be thrown/caught instead of having to rely on catching the very broad java.lang.Exception which is going to be quite error prone.

tfmorris added a commit to tfmorris/pattypan that referenced this issue Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant