From 40ca8c73f3d0bd14495f157a67148a3f9bc67a28 Mon Sep 17 00:00:00 2001 From: Martijn van Beurden Date: Fri, 4 Oct 2024 13:03:01 +0200 Subject: [PATCH] Only fail on memory allocation after initializing other variables (#747) As this issue was not reproducible, this might not actually be a fix. Credit: Oss-Fuzz Issue: https://issues.oss-fuzz.com/issues/42538252 --- src/flac/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/flac/main.c b/src/flac/main.c index 1b7a3a797b..4337ba140d 100644 --- a/src/flac/main.c +++ b/src/flac/main.c @@ -658,9 +658,6 @@ FLAC__bool init_options(void) option_values.num_files = 0; option_values.filenames = 0; - - if(0 == (option_values.vorbis_comment = FLAC__metadata_object_new(FLAC__METADATA_TYPE_VORBIS_COMMENT))) - return false; option_values.num_pictures = 0; option_values.debug.disable_constant_subframes = false; @@ -668,6 +665,9 @@ FLAC__bool init_options(void) option_values.debug.disable_verbatim_subframes = false; option_values.debug.do_md5 = true; + if(0 == (option_values.vorbis_comment = FLAC__metadata_object_new(FLAC__METADATA_TYPE_VORBIS_COMMENT))) + return false; + return true; }