Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AcceptSslCertificatesWithCustomValidationCallbackNSUrlSessionHandler fails #21912

Open
rolfbjarne opened this issue Jan 7, 2025 · 1 comment
Labels
tests Anything related to tests
Milestone

Comments

@rolfbjarne
Copy link
Member

The test fails with:

[FAIL] AcceptSslCertificatesWithCustomValidationCallbackNSUrlSessionHandler("https://self-signed.badssl.com/") :   Status code was not success
[FAIL] AcceptSslCertificatesWithCustomValidationCallbackNSUrlSessionHandler("https://wrong.host.badssl.com/") :   Status code was not success

Debugging a bit it seems that these return 404 "Not Found" now, so it seems something changed on badssl.com's side.

We should probably use a different server we control (maybe look into if dotnet/runtime has something we can use?)

@rolfbjarne rolfbjarne added the tests Anything related to tests label Jan 7, 2025
@rolfbjarne rolfbjarne added this to the Future milestone Jan 7, 2025
rolfbjarne added a commit that referenced this issue Jan 7, 2025
…SessionHandler - fails due to external factors.

The test fails with:

    [FAIL] AcceptSslCertificatesWithCustomValidationCallbackNSUrlSessionHandler("https://self-signed.badssl.com/") :   Status code was not success
    [FAIL] AcceptSslCertificatesWithCustomValidationCallbackNSUrlSessionHandler("https://wrong.host.badssl.com/") :   Status code was not success

Debugging a bit it seems that these return 404 "Not Found" now, so it seems something changed on badssl.com's side.

We should probably use a different server we control at some point, but filed
an issue for now (#21912).
@mcumming
Copy link
Contributor

mcumming commented Jan 7, 2025

One possibillity is to use Docker to host the badssl.com site: https://github.com/chromium/badssl.com/tree/master?tab=readme-ov-file#testing-and-development

rolfbjarne added a commit that referenced this issue Jan 8, 2025
…SessionHandler - fails due to external factors. (#21913)

The test fails with:

    [FAIL] AcceptSslCertificatesWithCustomValidationCallbackNSUrlSessionHandler("https://self-signed.badssl.com/") :   Status code was not success
    [FAIL] AcceptSslCertificatesWithCustomValidationCallbackNSUrlSessionHandler("https://wrong.host.badssl.com/") :   Status code was not success

Debugging a bit it seems that these return 404 "Not Found" now, so it seems something changed on badssl.com's side.

We should probably use a different server we control at some point, but filed
an issue for now (#21912).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Anything related to tests
Projects
None yet
Development

No branches or pull requests

2 participants