Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI]: stopping the gui should drop subscriptions before stopping the daemon and closing the window #1561

Open
edouardparis opened this issue Feb 4, 2025 · 0 comments

Comments

@edouardparis
Copy link
Member

From @jp1ac4:

If I close the GUI during IBD of managed bitcoind, there's a warning in the logs: WARN iced_futures::runtime:85: Stream could not run until completion: send failed because receiver is gone. I guess it's fine but perhaps there's a way to close the stream to avoid the warning?

We can have a 2 cycle stop instead of calling State .stop() immediatly on CloseOnRequest message.
first cycle will set stopping = true to the App and makes it stop any subscription by making app.subscription() return Subscription::none() and second cycle can stop the daemon and close the window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant