Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use transactions table in commands for better performance #1220

Closed
edouardparis opened this issue Jul 31, 2024 · 3 comments
Closed

Use transactions table in commands for better performance #1220

edouardparis opened this issue Jul 31, 2024 · 3 comments
Labels
Enhancement Improving an existing functionality Robustness Something could be made les brittle

Comments

@edouardparis
Copy link
Member

Actually daemon is fetching from bitcoind a lot of transactions for some commands, it would be more performant to use #1180 to fetch it in batch from the database.

@nondiremanuel nondiremanuel added Robustness Something could be made les brittle Enhancement Improving an existing functionality labels Jul 31, 2024
@nondiremanuel nondiremanuel added this to the v8 - Liana milestone Jul 31, 2024
@nondiremanuel nondiremanuel moved this to To be discussed / defined in Liana General Jul 31, 2024
@darosior
Copy link
Member

darosior commented Aug 2, 2024

I'm not sure what you are suggesting. After #1180 transactions are only fetched once from bitcoind and otherwise always queried from DB.

@edouardparis
Copy link
Member Author

Ah right 90df14c#diff-bf2f650cdc66abd13076c47b25e8c9f783f06ec335bbd30822fdd690547615fdR1034
I thought #1180 will not handle this kind of batch fetch.

@nondiremanuel nondiremanuel moved this from To be discussed / defined to Done in Liana General Aug 2, 2024
@nondiremanuel nondiremanuel removed this from the v8 - Liana milestone Aug 2, 2024
@jp1ac4
Copy link
Collaborator

jp1ac4 commented Aug 2, 2024

Oh sorry, I thought there might have been something still to do, but yes it seems that PR already took care of everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improving an existing functionality Robustness Something could be made les brittle
Projects
Status: Done
Development

No branches or pull requests

4 participants