Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU Temp (Text) in System Tray #2345

Open
MonsterSe7en opened this issue Dec 24, 2024 · 3 comments
Open

CPU Temp (Text) in System Tray #2345

MonsterSe7en opened this issue Dec 24, 2024 · 3 comments
Assignees

Comments

@MonsterSe7en
Copy link

Description of the feature, modification, idea or suggestion

Hey Thank you for your work of passion, I love and use the software regularly!!

Would love to have a CPU Temperature monitor in my System Tray like there's one for GPU Temp

Please check the 2nd Icon (GPU Temp)
image

Would love a CPU Temp (Text) option as well like GPU Temp (Text)
Please refer last option under Tray Icons in Screenshot!
image

Proposed implementation details (optional)

No response

@jxy-s
Copy link
Member

jxy-s commented Jan 3, 2025

Getting the CPU temperature unfortunately requires modifications to the driver to support reading MSRs and/or PCI configuration. While some systems use thermal zones, they are not always available. To provide proper support, similar to other tools, it would require exposing potentially sensitive APIs through the driver. Additionally, this involves CPU model-specific handling, which would need to be maintained and kept up to date.

I am very interested in this subject and would like to implement this capability into System Informer so that I don’t have to rely on other tools. I’m willing to invest the time to implement this as safely and reasonably as possible within System Informer. This is something I will take on myself. However, I can’t guarantee when it will be completed, as it depends on having the time to do it properly.

@jxy-s jxy-s self-assigned this Jan 3, 2025
@b1scu1t
Copy link

b1scu1t commented Jan 7, 2025

Getting the CPU temperature unfortunately requires modifications to the driver to support reading MSRs and/or PCI configuration. While some systems use thermal zones, they are not always available. To provide proper support, similar to other tools, it would require exposing potentially sensitive APIs through the driver. Additionally, this involves CPU model-specific handling, which would need to be maintained and kept up to date.

I am very interested in this subject and would like to implement this capability into System Informer so that I don’t have to rely on other tools. I’m willing to invest the time to implement this as safely and reasonably as possible within System Informer. This is something I will take on myself. However, I can’t guarantee when it will be completed, as it depends on having the time to do it properly.

Maybe instead of a homegrown solution, maybe you can use an existing library to handle this?
I think LibreHarwareMonitorLib can be used to handle GPU and CPU temps (and a lot more, but SI has most of them already).

@jxy-s
Copy link
Member

jxy-s commented Jan 7, 2025

LibreHardwareMonitor uses WinRing0. We will not be pulling that into the project. WinRing0 is used is many BYOVD and exploits.

Like I mentioned, "as safely and reasonably as possible" - almost every hardware monitoring solution is plagued with vulnerabilities that are routinely exploited. In order for System Informer to provide this functionality we will have to provide similar APIs but we must do it safely. We likely do not need the entire API surface that is normally exposed in hardware monitoring and configuration solutions or libraries. And most importantly we must leverage the security model of our own driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants