Skip to content
This repository has been archived by the owner on Apr 16, 2023. It is now read-only.

Defining workflow for local development as the library evolves #9

Open
maskaravivek opened this issue Apr 21, 2019 · 1 comment
Open

Comments

@maskaravivek
Copy link
Contributor

maskaravivek commented Apr 21, 2019

@dbrant Thanks to your library, we have kickstarted the process of network overhaul in the commons app (part of commons-app/apps-android-commons#1092).

As you mentioned earlier, the library isn't fully ready for usage and there are minor bits and pieces that would keep changing as we go forward. As of now whenever there's any change required in the library(mostly minor changes like adding a getter method, changing the access modifiers etc.), we wait for the PR to be merged, the version to be bumped and then having the change available for usage.

I tried adding the library as a module project but ran into build issues with this task failing :app:compileProdDebugJavaWithJavac. I guess thats because bintray settings were not available.

implementation project(":wikimedia-android-data-client")

I was hoping to get an idea about what would be the best workflow while we incorporate the library in the app. It would be great if you could briefly guide me on how to use the library as a module or how to host a snapshot on maven, that we can use while developing.

@misaochan
Copy link

misaochan commented Apr 22, 2019

Seconding Vivek's request, as we are trying to get the upload & network backend overhauled ASAP so that we can solve the failed uploads problem for our users, which is still a big issue at the moment. :) Thanks so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants