Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solara.Meta adds an empty span to DOM #626

Open
iisakkirotko opened this issue May 1, 2024 · 1 comment · Fixed by #625
Open

solara.Meta adds an empty span to DOM #626

iisakkirotko opened this issue May 1, 2024 · 1 comment · Fixed by #625
Milestone
Solara 2.0

Comments

@iisakkirotko
Copy link
Collaborator

This can have unexpected consequences for spacing when, for instance, using flex-boxes with a set gap, like the ones that are automatically added if an element has more than one direct child.

An example issue can be found in the linked PR
@iisakkirotko iisakkirotko added this to the Solara 2.0 milestone May 1, 2024
@iisakkirotko iisakkirotko mentioned this issue May 1, 2024
Merged
1 task
iisakkirotko added a commit that referenced this issue May 1, 2024
@iisakkirotko
fix[docs]: remove extra space from top of jupyter dashboard tutorial
c2f8fc4 
Under the hood this was caused by #626. But since the proper solution is potentially breaking, we are saving it for Solara 2.0
@iisakkirotko iisakkirotko mentioned this issue May 1, 2024
Merged
iisakkirotko added a commit that referenced this issue May 1, 2024
@iisakkirotko
fix[docs]: remove extra space from top of jupyter dashboard tutorial
98aa548 
Under the hood this was caused by #626. But since the proper solution is potentially breaking, we are saving it for Solara 2.0
iisakkirotko added a commit that referenced this issue May 1, 2024
@iisakkirotko
fix[docs]: remove extra space from top of jupyter dashboard tutorial (#…
c1a3fef 
…627)

Under the hood this was caused by #626. But since the proper solution is potentially breaking, we are saving it for Solara 2.0
@maartenbreddels
Copy link
Contributor

I think we should check all empty spans, and make sure we are compatible with ipyvue < 1.11.0
widgetti/ipyvue#92

@iisakkirotko iisakkirotko mentioned this issue Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Solara 2.0
Development

Successfully merging a pull request may close this issue.

fix!: solara.Meta elements insert empty span into DOM widgetti/solara
2 participants
@maartenbreddels @iisakkirotko