Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Type Conversion #5

Open
TheMellyBee opened this issue Apr 19, 2022 · 0 comments
Open

Refactoring Type Conversion #5

TheMellyBee opened this issue Apr 19, 2022 · 0 comments

Comments

@TheMellyBee
Copy link

Problem

Needing to cast floats to doubles in datasketches using the templates. Solution shown in linked PR works, but it would be nice to refactor it slightly.

Proposed changes

  1. Making the variables private instead of public
  2. Understanding the allocator code and simplifying

Originally posted by @TheMellyBee in #4 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheMellyBee