-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"timer initialization steps" perform EnsureCSPDoesNotBlockStringCompilation with undefined timer value #10824
Comments
This was decided as the format to use when I was upstreaming changes. There's no consistency with how enum values are written at the minute. |
I would indeed prefer to match ES's formatting and use "TIMER". I guess we should do all the enums at once though. It'd be even better if we could link to the definitions of the enum values in the ES spec, but I don't know if they have proper |
I did look at this when reviewing, but the problem is that they use |
I'm not sure the semantics/experience is significantly different... the end effect that, e.g., AT or users see, is just the uppercase text. And it's not clear there's any "semantics" being conveyed by the implementation choice they've made. |
I guess I'd be fine with actually typing uppercase. Looping in other 262 editors @bakkot and @michaelficarra. |
I forget why we decided to use a text transform instead of just making it actually uppercase to begin with. I'm fine with changing the source if there's not a compelling reason not to. Re: copying, we're considering having ecmarkup add some hidden text with tildes so these values would copy as |
We only did it as a CSS |
What is the issue with the HTML Standard?
cc @lukewarlow @koto @nicolo-ribaudo
See https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html#dom-setinterval
Step 9.6.3 reads
but
timer
is not defined in previous steps.It seems https://w3c.github.io/webappsec-csp/#can-compile-strings instead expects the value "TIMER".
(Note that function is also called from https://html.spec.whatwg.org/multipage/webappapis.html#hostensurecancompilestrings(realm,-parameterstrings,-bodystring,-codestring,-compilationtype,-parameterargs,-bodyarg), which passes the enum value from https://tc39.es/proposal-dynamic-code-brand-checks/#sec-hostensurecancompilestrings)
The text was updated successfully, but these errors were encountered: