Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty root object message #22

Open
romancow opened this issue Oct 9, 2023 · 3 comments
Open

Empty root object message #22

romancow opened this issue Oct 9, 2023 · 3 comments

Comments

@romancow
Copy link
Collaborator

romancow commented Oct 9, 2023

Would probably be nice to show some sort of message conveying that the root object does not have any properties when this is the case, so people aren't confused by just an empty form. Probably should be configurable (via UI options) so it can be tailored to the specific use case.

@brollb
Copy link
Collaborator

brollb commented Oct 9, 2023

This might not be bad but I would lean toward saying that it is out of scope and then leaving it to the rest of the site to present a meaningful message if there isn't a meaningful JSON schema. The tricky thing about taking this on is that there could be a lot of different opinions about look & feel that might be nice to avoid.

@romancow
Copy link
Collaborator Author

romancow commented Oct 9, 2023

My only thought was, with some taxonomies, there is a title, but no properties. So it might be nice to have a way to easily "insert" a message inside the form - between the title and any action buttons. This could easily be customizable by using a slot. It could even just be a generic "message" slot, leaving the consumer the responsibility of testing for emptiness and showing their message.

@romancow
Copy link
Collaborator Author

romancow commented Oct 9, 2023

Also, I'd imagine this is pretty low priority. I just noticed when I hit a taxonomy that was empty, I kept wondering if something was broken, so thought I'd take a note of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants