Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rjs-build should throw error compilation fail #8

Open
nabana opened this issue Dec 4, 2014 · 1 comment
Open

rjs-build should throw error compilation fail #8

nabana opened this issue Dec 4, 2014 · 1 comment
Assignees

Comments

@nabana
Copy link
Contributor

nabana commented Dec 4, 2014

Please alter the rjs-build task to transclude the error message from r.js if build fails. That is a big build step and would be important to know if it passes. It also includes sources from webgme and domain tools repositories and it would be a good indication of not having the most up-to-date versions installed. (like it happened to me today)

Current format:

    exec('node ./node_modules/requirejs/bin/r.js -o ./utils/build/webcyphy.plugins/cbuild.js', function () {
        console.log('Done requireJS build!');
    });
@pmeijer
Copy link
Contributor

pmeijer commented Dec 10, 2014

I've fixed the error propagation, however I'm not sure if it's feasible to guarantee the latest webgme/-domain-tools. The are not required by version (currently) and to pull the master branches each build would be painfully slow. I'm open for suggestions here though..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants