Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using hashp with shadow-cljs emits undeclared-var warnings #15

Open
maxrothman opened this issue Apr 5, 2021 · 2 comments
Open

Using hashp with shadow-cljs emits undeclared-var warnings #15

maxrothman opened this issue Apr 5, 2021 · 2 comments

Comments

@maxrothman
Copy link

I set up hashp in my shadow-cljs project as per the README (slightly abbreviated):

{:source-paths
 ["src/dev"
  "src/main"
  "src/test"]

 :dependencies
 [[hashp "0.2.1"]]

 :builds
 {:frontend {:target :browser
             :modules {:main {:init-fn spell-list.main/init}}
             :devtools {:preloads [hashp.core]}}}}

When I start the dev build, I get 39 instances of the following warning:

------ WARNING #1 - :undeclared-var --------------------------------------------
 Resource: sci/impl/fns.cljc:141:28
 Use of undeclared Var sci.impl.fns/clojure
--------------------------------------------------------------------------------

Hashp still works regardless of those errors, but it might be something worth looking into?

@viesti
Copy link
Contributor

viesti commented Sep 2, 2022

Seems that bumping zprint to current latest (1.2.4) helped for me (sci dependency seems to come from zprint).

@viesti
Copy link
Contributor

viesti commented Oct 11, 2022

Also, when using clojure 1.11.1, there's a warning on zprint's use of it's own abs function, which is now in clojure.core:

WARNING: abs already refers to: #'clojure.core/abs in namespace: zprint.range, being replaced by: #'zprint.range/abs

I guess if users don't specify the Clojure version used, bumping zpint would land them to 1.11.1, but I guess the Clojure version should usually be specified in application projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants