Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformer is not compatible with coil 2.0 #7

Closed
mori-atsushi opened this issue Mar 2, 2022 · 2 comments · Fixed by #8
Closed

Transformer is not compatible with coil 2.0 #7

mori-atsushi opened this issue Mar 2, 2022 · 2 comments · Fixed by #8

Comments

@mori-atsushi
Copy link
Contributor

Coil will make a big breaking change in 2.0.
Now, many Transformation for Coil, including BlurTransformation, throw an AbstractMethodError and do not work with Coil 2.0.

At least the following two changes are required.

  • Transformation.key is replaced with Transformation.cacheKey.
  • BitmapPool and PoolableViewTarget have been removed from the library.

Since Coil 2.0 is alpha, it may changes until the stable release.

Can I make a Pull Request?
@mori-atsushi mori-atsushi changed the title Transformer is not compatible with coil 2 series Transformer is not compatible with coil 2.0 Mar 2, 2022
@wasabeef
Copy link
Owner

wasabeef commented Mar 3, 2022

@mori-atsushi
Thank you for teaching me about that. if you make the PR, I'll check that.

@mori-atsushi mori-atsushi mentioned this issue Mar 9, 2022
Merged
@Qdafengzi
Copy link

update time ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update coil 2.0.0-rc01 mori-atsushi/transformers
3 participants
@wasabeef @mori-atsushi @Qdafengzi