Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new language: ko #563

Closed
Jeong-minji opened this issue Aug 6, 2024 · 1 comment
Closed

Adding new language: ko #563

Jeong-minji opened this issue Aug 6, 2024 · 1 comment

Comments

@Jeong-minji
Copy link

#529

I referenced the above issue, and I want to contribute new language ko (Korean).
I will make small incremental CRs after making new codes.

I have few questions,

  • Do I just need to specify @wanasit as a reviewer?
  • Is there a convention for the test case or should I write them autonomously?
@wanasit
Copy link
Owner

wanasit commented Aug 9, 2024

Hello. Thanks for reaching out.

Do I just need to specify @wanasit as a reviewer?

Yes. Or just create a Merge Request; I'll look at the change.

Is there a convention for the test case or should I write them autonomously?

There is a strict convention, but please follow the existing tests.
Note that I (and other contributors) don't speak Korean, the tests should be easy to understand.

Anyway, don't worry too much.
If it's not too large change, I'll check and approve it as soon as I can.

@wanasit wanasit closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants