Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url getter special cases data: URLs #64

Open
annevk opened this issue Oct 22, 2021 · 2 comments
Open

url getter special cases data: URLs #64

annevk opened this issue Oct 22, 2021 · 2 comments

Comments

@annevk
Copy link
Member

annevk commented Oct 22, 2021

Why special case data: URLs? Other URLs can be thousands of code points as well...

@npm1
Copy link
Collaborator

npm1 commented Oct 25, 2021

Is that common though? The thinking was to align with Resource Timing on URLs that are fetched (that API does not trim URL names) but to not store the enormous URL for inline images which are in data: URLs.

@mmocny
Copy link

mmocny commented Nov 15, 2021

If we wanted to consistently truncate all URLs, rather than to rely on a convention which works well most but not all of the time, we discussed some options today:

  • Truncate all URLs, but increase the number of codepoints to something larger, like 1k-4k
  • Truncate all URLs to 100 code points-- but then also add a hash of the full URL
  • Change to only return a hash of the URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants