Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definitions related to image loading are not precise #43

Open
yoavweiss opened this issue Mar 19, 2020 · 1 comment
Open

Definitions related to image loading are not precise #43

yoavweiss opened this issue Mar 19, 2020 · 1 comment

Comments

@yoavweiss
Copy link
Collaborator

In 3.7 step 1.2, "fully decoded" should probably be fully decodable

There are also references to "completely available" which may fire earlier than we would like - when the image dimensions are known, rather than when it's fully decoded.

@npm1 - thoughts?

@yoavweiss yoavweiss changed the title Definition related to image loading are not precise Definitions related to image loading are not precise Mar 19, 2020
@npm1
Copy link
Collaborator

npm1 commented Mar 19, 2020

Oh hmm reading more what fully decodable says I think it implies that the image is ready to be decoded but is not necessarily decoded yet, so I don't think that works for the purposes of Element Timing. Here, we want to know when the image has already been fully decoded.

Regarding the latter part, I do think we could replace completely available with fully decodable since the latter better captures when the image is 'loaded'. I think the main difference is that this would exclude images which having decoding problems from being reported (which I think is pretty reasonable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants