Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update relevant unit tests to include "Accept" header in requests #574

Closed
rhofvendahl opened this issue Jul 10, 2023 · 7 comments
Closed
Assignees

Comments

@rhofvendahl
Copy link
Collaborator

rhofvendahl commented Jul 10, 2023

Currently the Accept header is used in Issue and Verify requests to specify the format of the verifiable credential. Legitimate values are vc (for json VCs with linked data proofs), vc-jwt, and (pending discussion) vc-cwt.

@rhofvendahl
Copy link
Collaborator Author

Use of Content-Type is now uncertain - see discussion on #573

@nissimsan
Copy link
Collaborator

Ping @rhofvendahl

@rhofvendahl
Copy link
Collaborator Author

@OR13 when we discussed this in August I believe you recommended making an issue (w3c/vc-jose-cose-test-suite#8) in https://github.com/w3c/vc-jose-cose-test-suite, so that these changes could be referenced by multiple projects. It's looking like there hasn't been any activity in that project in the past month, though.

Do you know if that project is still moving forward? If it isn't actively being worked on, I'd be happy to move ahead with implementing this in the trace-interop repo.

@OR13
Copy link
Collaborator

OR13 commented Oct 2, 2023

Yes, prefer work to be done in a place where the working group can benefit

@rhofvendahl
Copy link
Collaborator Author

So you do expect vc-jose-cose-test-suite project to move forward? If that's the case I suppose I should just take on the issue there, as there doesn't seem to be many active developers at this time.

@rhofvendahl rhofvendahl changed the title Update relevant unit tests to include "Content-Type" header in requests Update relevant unit tests to include "Accept" header in requests Oct 17, 2023
@rhofvendahl
Copy link
Collaborator Author

Still WIP

@rhofvendahl
Copy link
Collaborator Author

I've broken this into two PRs: #605 for updating Accept headers, and #606 for adding a test for the requirement of Accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants