Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:+ and :- break indentation of + and - in SLIME #16

Open
orivej opened this issue Nov 7, 2014 · 3 comments
Open

:+ and :- break indentation of + and - in SLIME #16

orivej opened this issue Nov 7, 2014 · 3 comments

Comments

@orivej
Copy link
Contributor

orivej commented Nov 7, 2014

Since incf and decf are macros, and macro definitions alter SLIME indentation of all symbols with the same name regardless of their package, loading rutils alters indentation of + and -.

In SBCL, before loading rutils:

(+ (f)
   1
   2)

after loading rutils:

(+ (f)
    1
    2)

This can be fixed either by evaluating (put '+ 'common-lisp-indent-function '(as nil)) (same with '-) in Emacs (and describing this workaround in rutils wherever :+ and :- and defined or documented), or by altering swank:*application-hints-tables* accordingly (as implemented in trivial-indent).

@vseloved
Copy link
Owner

vseloved commented Nov 7, 2014

I see your point. So, are there any actions that can be taken here on the rutils side?

@orivej
Copy link
Contributor Author

orivej commented Nov 7, 2014

Yes; I could propose a patch. Do you prefer to introduce dependency on trivial-indent, or to manipulate swank:*application-hints-tables* directly?

@vseloved
Copy link
Owner

vseloved commented Nov 8, 2014

I think, using trivial-indent is ok. I have a few more indent changes for other things in mind, as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants