Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env: Package ordering #389

Open
Tracked by #395
dominiquesydow opened this issue Jun 4, 2023 · 0 comments
Open
Tracked by #395

Env: Package ordering #389

dominiquesydow opened this issue Jun 4, 2023 · 0 comments
Assignees
Labels
dependency Update/fix dependencies documentation Update/fix documentation

Comments

@dominiquesydow
Copy link
Collaborator

dominiquesydow commented Jun 4, 2023

In the current env file, some third party packages are listed before Python and Pip.
Can we please go back to the class order of first listing the big important packages, and then going into the talktorial/domain packages?

https://github.com/volkamerlab/teachopencadd/blob/master/devtools/test_env.yml

dependencies:
  - mkl < 2022
  - pytorch::pytorch==1.13.0
  #- pyg::pyg==2.2.0
  - python>=3.8
  - pip

For the conda recipe, I will go back to the classic order:
https://github.com/conda-forge/teachopencadd-feedstock/blob/main/recipe/meta.yaml
and here the PR branch:
https://github.com/conda-forge/teachopencadd-feedstock/blob/42716b39f7e60963bfb160e4cc0faa51c3ce905d/recipe/meta.yaml

If this causes issues, we will have to cut another conda release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Update/fix dependencies documentation Update/fix documentation
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants