Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CICD] Release docker images on GHCR #734

Open
gaocegege opened this issue Feb 24, 2025 · 1 comment
Open

[CICD] Release docker images on GHCR #734

gaocegege opened this issue Feb 24, 2025 · 1 comment
Labels
area/cicd priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@gaocegege
Copy link
Collaborator

🚀 Feature Description and Motivation

Since Docker Hub has pull limits, switching to using GitHub Container Registry might be better for releasing our images. It could save us some hassle and keep things running smoothly.

Use Case

N/A

Proposed Solution

No response

@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 24, 2025

Agree. it used to have GHCR build

# TODO: Disable GHCR at this moment after org transfer, let's enable it later.
# - name: Build Container Images with Github Container Registry prefix
# run: |
# GIT_COMMIT_HASH=${{ github.sha }} AIBRIX_CONTAINER_REGISTRY_NAMESPACE=ghcr.io/aibrix make docker-build-all
#
# - name: Push Container Images to Github Container Registry
# run: |
# GIT_COMMIT_HASH=${{ github.sha }} AIBRIX_CONTAINER_REGISTRY_NAMESPACE=ghcr.io/aibrix make docker-push-all

After we transferred the repo, it doesn't have package write permission. We can resolve this issue either adopting previous orgs or ask vLLM maintainers to grant the permission here.

@Jeffwan Jeffwan added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

2 participants