Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--master-gpu has no effect #30

Open
vlimant opened this issue Mar 7, 2019 · 0 comments
Open

--master-gpu has no effect #30

vlimant opened this issue Mar 7, 2019 · 0 comments

Comments

@vlimant
Copy link
Owner

vlimant commented Mar 7, 2019

https://github.com/vlimant/mpi_learn/blob/master/mpi_learn/mpi/manager.py#L29
in

def get_device(comm, num_masters=1, gpu_limit=-1, gpu_for_master=False):

gpu_for_master is not used anymore, and I think it is hard to know at that point whether the global rank is a "master" or not.
We might need to change the location of the device discovery closer to where models are created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant