Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper logging to match expectations from TakoTako #12

Open
vivaria opened this issue Jun 3, 2023 · 0 comments
Open

Add proper logging to match expectations from TakoTako #12

vivaria opened this issue Jun 3, 2023 · 0 comments
Assignees
Labels
logging Exceptions and other text printed to the console

Comments

@vivaria
Copy link
Owner

vivaria commented Jun 3, 2023

TakoTako's ConvertTJA.exe utility checks for specific logging messages to make sure that no errors have occurred. But, if a general Python exception is thrown (e.g. NotImplementedError, ValueError) without the specific keywords, then TakoTako just... won't print the error message to the log at all? Which is very unhelpful when something goes wrong.

So, tja2fumen should probably attempt to mimic what tja2bin does, so that it can function as a drop-in replacement for tja2bin.

@vivaria vivaria added the feature New feature or request label Jun 3, 2023
@vivaria vivaria self-assigned this Jun 3, 2023
@vivaria vivaria added logging Exceptions and other text printed to the console and removed feature New feature or request labels Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging Exceptions and other text printed to the console
Projects
None yet
Development

No branches or pull requests

1 participant