Feat: Add a changelog section on hompage #1907
Conversation
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I like this! One suggestion I have though is not to use release blog posts in the changelog. Instead, can you use the following? |
There was a problem hiding this comment.
Nice! Thank you for working on this. I will echo @deepthi's comments. I also think we may as well retroactively generate some changelog entires based on Vitess changelog commits.
Sweet! I imagine we will have to do some docs pre-processing to make this work? I don't know. We can always play around and improve this workflow. Let's do this in a separate PR if possible. |
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
|
@thisisobate if you can accept the netlify invite I sent you, we won't need to manually approve deploy previews on your PRs. |
We can handcraft the retroactive changelings, but I agree that should be a separate PR. |
|
This looks great on web and tablet. On mobile (iPhone), it could be better if you can push the "view all changes" link to the right. Not sure why it isn't right justified on iPhone the way it is on iPad / Safari on web.
|
|
ok..will fix right away |
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
|
@deepthi Fixed the layout issue on mobile |
There was a problem hiding this comment.
Left some comments and nits. This is really good and the web + mobile versions look good to me.
One comment, there is a lot of duplication between the changelog folder and the blog post folder. It would be nice if we can use symlink, or another system to avoid having to change two files in two different places when we need to edit a blog post.
I'll approve and not merge yet to allow @deepthi and @shlomi-noach to give more feedback.
frouioui
added
the
do-not-merge
Good point but honestly, I think we will only have the issue of duplicates for these first 4 blog posts. Newer ones will have to be added to the changelog directory directly. Btw, it looks like symlink is not supported on Hugo: https://discourse.gohugo.io/t/symbolic-links-not-supported/590 |
Signed-off-by: thisisobate <[email protected]>
Signed-off-by: thisisobate <[email protected]>
Todo
Fixes #1851