Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_user should be named update_user and needs to update, not overwrite, the user data. #49

Open
ryan-talus opened this issue Mar 9, 2023 · 3 comments
Open

create_user should be named update_user and needs to update, not overwrite, the user data. #49

ryan-talus opened this issue Mar 9, 2023 · 3 comments
Assignees
@ryan-talus

Comments

@ryan-talus
Copy link
Member

No description provided.

@ryan-talus ryan-talus self-assigned this Mar 9, 2023
@ryan-talus
Copy link
Member Author

Currently calls USERS_TABLE.put_item() and should be USERS_TABLE.update_item().

As it is right now, a client with out of date data could save the wrong projects array, making a user's projects potentially "disappear".

@ryan-talus
Copy link
Member Author

https://github.com/talus-analytics-bus/pharos-api/blob/762171e508980fa1092cb96f1d7ef8aaba6d2906/src/lambda/create_user/app.py#L21

ryan-talus added a commit that referenced this issue Mar 10, 2023
@ryan-talus
Adding todo; created issue #49 to rename / refactor this
2129a98
@ryan-talus
Copy link
Member Author

This also needs to have the ability to create users removed and moved to a separate function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryan-talus ryan-talus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryan-talus