crates/floresta-compact-filters/src/lib.rs

@@ -113,7 +113,7 @@ impl BlockFilterBackend {
     /// Creates a new [BlockFilterBackend].
     ///
     /// Storage is a database used for storing and retrieving filters. May be anything
-    /// that implements [BlockFilterStore]. 
+    /// that implements [BlockFilterStore].
     /// Key is a 256-bytes element that'll be used as key for the siphash iside our filters.
     /// BIP-158 defines this key as the hash of each block, since they need a public parameter,
     /// and a fixed one may be exploited by bad actors trying to trick a wallet into having many
@@ -161,7 +161,7 @@ impl BlockFilterBackend {
     /// if at least one query mathes. It'll return a vector of block heights where it matches.
     /// you should download those blocks and see what if there's anything interesting.
     pub fn match_any(&self, start: u64, end: u64, query: &[QueryType]) -> Option<Vec<u64>> {
-        let mut values = query.into_iter().map(|filter| &*filter.into_slice());
+        let mut values = query.iter().map(|filter| filter.as_slice());
 
         let mut blocks = Vec::new();
 
@@ -215,7 +215,7 @@ impl BlockFilterBackend {
     }
     fn write_outputs(&self, txs: &Vec<Transaction>, filter: &mut FilterBuilder) {
         for tx in txs {
-            self.write_tx_outs(&tx, filter);
+            self.write_tx_outs(tx, filter);
         }
     }
 }
@@ -330,7 +330,7 @@ pub enum QueryType {
 }
 
 impl QueryType {
-    pub(crate) fn into_slice(&self) -> &[u8] {
+    pub(crate) fn as_slice(&self) -> &[u8] {
         match self {
             QueryType::Txid(txid) => txid.as_inner().as_slice(),
             QueryType::Input(outpoint) => &outpoint.0,
@@ -390,7 +390,7 @@ mod tests {
                 &mut [value].iter().copied(),
             )
             .unwrap();
-        assert_eq!(res, true);
+        assert!(res);
 
         let value = [11_u8; 42].as_slice();
         let res = filter
@@ -399,7 +399,7 @@ mod tests {
                 &mut [value].iter().copied(),
             )
             .unwrap();
-        assert_eq!(res, false);
+        assert!(!res);
     }
 
     #[test]