Add option to process entire replay directory or just selected files #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this PR! I think the functionality itself seems mostly fine but like you mentioned, since the Electron API for Mac and Windows doesn't allow choosing both files and folders I feel having those radio options overly complicates the user experience. Turning enabled buttons to disabled but still visible also doesn't help in that regard either. I'm going to leave this PR unmerged until we can achieve a better UI/UX. |
|
Yeah that's totally fair, I'll stew on it for a bit and see if I can come up with anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant part of the replay processor now looks like this:
If you select the "Select by individual files" radio button it changes to:
Note that "Include subfolders" and "Open location" buttons get greyed out when you do this.
I'm open to other UIs, this is not my forte.
Going in to this change I was surprised to learn that neither Windows nor macOS let you open a file picker that allows you to select both directories and files, but Linux does. That made this slightly less elegant to implement than I had hoped. I would have liked the
FileInputcomponent to be able to select one directory, one file, or multiple files but I couldn't get this to work with TypeScript in a sound way and it seemed to be fighting the way the OS APIs want things to work anyways.Happy to make any changes necessary, and if you decide this isn't a change you want to include no worries. :)
Thanks for building and maintaining this!
Fixes #89