Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders are not included directly #8

Open
kvark opened this issue Aug 21, 2021 · 5 comments
Open

Folders are not included directly #8

kvark opened this issue Aug 21, 2021 · 5 comments

Comments

@kvark
Copy link

kvark commented Aug 21, 2021

Looks like the contents of the folders are included instead of the folders themselves.
https://github.com/kvark/vange-rs/runs/3389417025?check_suite_focus=true

Run papeloto/action-zip@v1
  with:
    files: res config road model car level convert
    dest: vangers-macos-latest.zip
    recursive: true
Ready to zip "res config road model car level convert" into vangers-macos-latest.zip
  - res
  - config
  - road
  - model
  - car
  - level
  - convert

Zipped file vangers-macos-latest.zip successfully

Downloading the file and unzipping it shows me:

graphics35334:vangers-macos-latest dmalyshau$ ls -l
total 60632
-rw-rw-r--@  1 dmalyshau  staff  7109656 21 Aug  2021 car
-rw-rw-r--@  1 dmalyshau  staff  1751632 21 Aug  2021 convert
-rw-rw-r--@  1 dmalyshau  staff  7396816 21 Aug  2021 level
-rw-rw-r--@  1 dmalyshau  staff  7016240 21 Aug  2021 model
-rw-rw-r--@  1 dmalyshau  staff  7759656 21 Aug  2021 road
-rw-rw-r--@  1 dmalyshau  staff     1571 21 Aug  2021 settings.template.ron
drwxrwxr-x@ 20 dmalyshau  staff      640 21 Aug  2021 shader

So, instead of res folder, the archive contains the shader folder, which is inside. Same for config, which is absent, but the file from it is here.

@bahag-welscha
Copy link

i have the same issue, the listed directory is not included in the zip only it's content is part of the zip

@Unity123
Copy link

This is actually good for me, I wanted my build to be listed as a release and I was worried it would have the folder structure.

@meskill
Copy link

meskill commented Sep 12, 2021

I think the docs about the recursive option is misleading as example works exactly opposite to docs. Settings recursive: false will put folders in archive as is

@epassaro
Copy link

I think the docs about the recursive option is misleading as example works exactly opposite to docs. Settings recursive: false will put folders in archive as is

You are right! The behavior is exactly the opposite.

@julillosamaral
Copy link
Contributor

Created this PR to fix the issue: #23

Better to change the docs than the code so if someone has it working the change won't affect their action.

Wunkolo added a commit to Wunkolo/vkblam that referenced this issue Feb 25, 2023
Seems to be the exact opposite to the documentation for action-zip...
vimtor/action-zip#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants