Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest a strategy to include absolute paths #11

Open
jgillis opened this issue Dec 21, 2021 · 2 comments
Open

Suggest a strategy to include absolute paths #11

jgillis opened this issue Dec 21, 2021 · 2 comments

Comments

@jgillis
Copy link
Contributor

jgillis commented Dec 21, 2021

If I understand correctly, the current implementation treats all paths as relative to GITHUB_WORKSPACE.
It would be great if we could have a strategy to support absolute paths, e.g. by:

  • introducing a default-true "relative" property
  • suggesting a way to change GITHUB_WORKSPACE to the empty string
@cschreib
Copy link

cschreib commented Nov 19, 2022

I second this. At first I tried setting working-directory, which didn't work (Unexpected value 'working-directory'). Then I tried giving all paths as absolute paths, which failed on Linux/OSX with (Not Found) (yet reported success and created an empty zip!) and on Windows with ENOENT: no such file or directory (this time properly reporting the failure). Then finally stumbled on this issue, which gave me the solution.

I think supporting working-directory would be the way to go.

@philosowaffle
Copy link

+1

I also avoid working with relative paths as much as possible. Allowing the user to control the input/output paths explicitly with absolute paths not only affords the most flexibility but also the most clarity around what this action is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants