-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate bash scripts dependencies #835
Comments
can you be more specific on what was rewritten and what wasn't? |
Yeah, All other scripts under |
can you please update the PR's description and enumerate the scripts that still need to be eliminated. this issue is not about what was already rewritten but what needs to. |
I don't think that's completely done. If I remember correctly, we still have shell scripts for setting up the cri runners. |
Currently there exists some complicated dependencies between some setup bash scripts, like the figure shown below:
Actually, most of them have been rewritten with Go, but to remove them completely, some modifications of files under
scripts/github_runner
directory need to be appliedFYI, below are lists of bash scripts which have been rewritten and should have been removed if dependency issues were fixed:
scripts/setup_system.sh
scripts/setup_gvisor_containerd.sh
scripts/install_go.sh
scripts/setup_firecracker_containerd.sh
scripts/install_stock.sh
scripts/install_pmutools.sh
scripts/setup_node.sh
The text was updated successfully, but these errors were encountered: