Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag enums should be typed #338

Open
buchanae opened this issue May 20, 2018 · 1 comment
Open

Flag enums should be typed #338

buchanae opened this issue May 20, 2018 · 1 comment
Labels
enhancement This issue asks for enhancement in a specific part
Milestone

Comments

@buchanae
Copy link

It would be very useful for documentation purposes if flag enums had types.

Currently, the signature for CreateWindow is:

func CreateWindow(title string, x, y, w, h int32, flags uint32) (*Window, error)

...where flags is just plain uint32. If this had a corresponding type WindowFlags uint32, I could easily navigate from the CreateWindow docs to the WindowFlags docs in godoc.org.

If there's no objection, I think I can manage making a PR.

@veeableful
Copy link
Contributor

Sounds good to me @buchanae! I'd very much like to have your PR if it's not too much trouble 😂

@veeableful veeableful added the enhancement This issue asks for enhancement in a specific part label May 22, 2018
@veeableful veeableful added this to the v0.4 milestone Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue asks for enhancement in a specific part
Projects
None yet
Development

No branches or pull requests

2 participants