You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would probably massively improve the value of the examples if they had comments.
I'd be interested in taking on some of this work and could create pull requests to be reviewed.
What motivated me to file this issue is actually a somewhat separate question, though, which I'd also appreciate clarification on while anybody reading is reading:
In the render_goroutines example, I'm not quite sure I understand the use of a mutex lock around running = false, since the mutex is not used anywhere else, so what is it really preventing? I'm writing a project in Go to learn it better so there's probably something I'm missing. Either way code comments could have made the example much richer.
The text was updated successfully, but these errors were encountered:
That's a good idea @dt-rush. The project always needs more improvements so PRs are always welcome and appreciated. Improving the examples is a nice start!
It would probably massively improve the value of the examples if they had comments.
I'd be interested in taking on some of this work and could create pull requests to be reviewed.
What motivated me to file this issue is actually a somewhat separate question, though, which I'd also appreciate clarification on while anybody reading is reading:
In the render_goroutines example, I'm not quite sure I understand the use of a mutex lock around
running = false
, since the mutex is not used anywhere else, so what is it really preventing? I'm writing a project in Go to learn it better so there's probably something I'm missing. Either way code comments could have made the example much richer.The text was updated successfully, but these errors were encountered: