New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node type constants #11

Merged

valtzu merged 3 commits into main from node-type-constants

Jan 11, 2025

Owner

valtzu commented Jan 1, 2025 •

edited

Loading

Using node.type.id instead of node.name means

we can use constants (from syntax.grammar.terms) instead of arbitrary strings + use node.type.is(...) method
we don't have to compare strings, which may improve performance (not benchmarked)

valtzu force-pushed the node-type-constants branch from ecc541f to f322d46 Compare

January 2, 2025 00:52

valtzu added 3 commits

January 11, 2025 20:21


          Use node.type.id instead of node.name

a7785f6


          Remove unused matchExact parameter

38e27b8


          Fix ts warning

57d753a

valtzu force-pushed the node-type-constants branch from f322d46 to 57d753a Compare

January 11, 2025 18:25

valtzu merged commit e479595 into main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet