Reduce argument count severity & improve message

valtzu · Jan 12, 2025 · 61835a7 · 61835a7
1 parent 866030f
commit 61835a7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ CHANGELOG
 * **BC BREAK:** Separate files are no longer included in the release (due to using `cm-buildhelper`)
 * Tests are now in TypeScript too
 * Autocomplete is now less aggressive
+* Severity of "too many arguments" linter error was lowered from error -> warning
 
 0.8
 ---

diff --git a/src/linter.ts b/src/linter.ts
@@ -33,7 +33,8 @@ export const expressionLanguageLinterSource = (state: EditorState) => {
 
         return;
       case Arguments:
-        const args = resolveFunctionDefinition(node.node.prevSibling, state, config)?.args;
+        const fn = resolveFunctionDefinition(node.node.prevSibling, state, config);
+        const args = fn?.args;
         if (!args) {
           return;
         }
@@ -44,7 +45,7 @@ export const expressionLanguageLinterSource = (state: EditorState) => {
           }
 
           if (i > args.length - 1) {
-            diagnostics.push({ from: n.from, to: n.to, severity: 'error', message: `Unexpected argument` });
+            diagnostics.push({ from: n.from, to: n.to, severity: 'warning', message: `Unexpected argument – <code>${fn.name}</code> takes ${args.length} argument${args.length == 1 ? '' : 's'}` });
             continue;
           }
 

diff --git a/test/test-linter.ts b/test/test-linter.ts
@@ -92,7 +92,7 @@ describe("Expression language linting", () => {
     ist(diagnostics.length, 1);
     ist(diagnostics[0].from, 18);
     ist(diagnostics[0].to, 19);
-    ist(diagnostics[0].message, "Unexpected argument");
+    ist(diagnostics[0].message, "Unexpected argument – <code>smash_my_head</code> takes 1 argument");
   });
 
   it("complains about wrong argument type using constant", () => {