mount_uploadcare_file makes network request every time model is saved

[jackc]

Describe the bug

Given an ActiveRecord model that has a mount_uploadcare_file attribute, a Uploadcare::FileApi.store_file is called on every save even when the mount_uploadcare_file attribute has not changed.

I would not expect a network request to be triggered when saving a model when the attribute hasn't changed.

The culprit seems to be:

uploadcare-rails/lib/uploadcare/rails/active_record/mount_uploadcare_file.rb

Line 50 in 428a7e6

after_save "uploadcare_store_#{attribute}!".to_sym unless Uploadcare::Rails.configuration.do_not_store

and

uploadcare-rails/lib/uploadcare/rails/active_record/mount_uploadcare_file.rb

Lines 34 to 40 in 428a7e6

	define_method "uploadcare_store_#{attribute}!" do |store_job = StoreFileJob|
	file_uuid = public_send(attribute)&.uuid
	return unless file_uuid
	return store_job.perform_later(file_uuid) if Uploadcare::Rails.configuration.store_files_async
	Uploadcare::FileApi.store_file(file_uuid)
	end

I presume this could be easily fixed by checking if the attribute has changed and only then making the API call, but perhaps the current behavior is handling some edge case I am not aware of.

[rsedykh]

Hi @jackc! Would you mind reviewing this one #128 ?

[jackc]

It works for me locally.