feat: add Bluesky account link on footer #346
Open
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuuji3
commented
Dec 28, 2024
Comment on lines
170
to
172
| x: { | ||
| url: 'https://x.com/unjsio', | ||
| icon: 'i-simple-icons-x', |
There was a problem hiding this comment.
I kept the original links here. But if UnJS Twitter account will no longer be active, I can also remove this link from the website.
|
I also noticed there are other twitter links in Blog post etc. If you'd like to update those, I can help update them as well (by this PR or the other PR). |
|
Aside from that, it'd be nice to add a Bluesky account link to
|
|
Thanks for nice work and suggstion. I have updated org, this repository needs little bit maintenance first. |
|
I made a separate PR to fix the lint errors on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolve #345
❓ Type of change
📚 Description
As written in the original issue, not having a Bluesky link makes it a bit difficult for new users to find a Bluesky account.
This PR adds two changes:
This helps new users find an account in an open platform where anyone who has Internet access can see the latest posts, unlike the other closed social media.
(with new Bluesky link icon)
(when hovering the mouse cursor)
📝 Checklist