Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MazeDataset - ensure different representations are always available #124

Closed
valedan opened this issue Mar 24, 2023 · 2 comments
Closed

MazeDataset - ensure different representations are always available #124

valedan opened this issue Mar 24, 2023 · 2 comments
Assignees

Comments

@valedan
Copy link
Contributor

valedan commented Mar 24, 2023

Currently it's possible to have a dataset where any of mazes_objs, mazes_tokens, and mazes_array are None. It would be nice if we could always rely on these representations being present.

I think a nice way to do this would be to choose one of these as the "canonical" representation, and have that be the only version that is actually stored. Then the other representations could be provided by functions that convert from the canonical version as needed. This should help tidy up __init__ too as right now there is a lot of code in there for converting between these formats.

@valedan valedan added enhancement New feature or request and removed enhancement New feature or request labels Apr 12, 2023
@mivanit
Copy link
Member

mivanit commented Apr 13, 2023

working on this on the zanj-integration-datasets branch (which, misleadingly, contains a rework of the datasets, training loop, and CLI for training).

rough plan:

  • integrate with ZANJ for easier saving/loading
  • canonical representation of a MazeDataset as a list of SolvedMaze
  • preserve the old interface via cached properties
  • seamlessly try to get a dataset from local file, download, or generate on the fly (see MazeDataset.from_config() function)
  • pass tests, add new ones
  • change to new interface in example notebooks and tests

@mivanit
Copy link
Member

mivanit commented Jun 16, 2023

resolved in #177

@mivanit mivanit closed this as completed Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants