Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inheritance for filters #8

Open
mivanit opened this issue Aug 22, 2023 · 0 comments
Open

fix inheritance for filters #8

mivanit opened this issue Aug 22, 2023 · 0 comments
Labels
bug Something isn't working code-quality code quality improvement high-priority This is important!

Comments

@mivanit
Copy link
Member

mivanit commented Aug 22, 2023

register_filter_namespace_for_dataset currently does some hacky things -- the behavior we want is for dataset.filter_by.some_filter to return the same type as dataset
@mivanit mivanit added bug Something isn't working code-quality code quality improvement high-priority This is important! labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working code-quality code quality improvement high-priority This is important!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mivanit